trie: remove isTruthy and isFalsy #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrocheleau
requested review from
faustbrian,
holgerd77,
acolytec3 and
jochem-brouwer
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
Thanks for the approval! I just made a minor update here: 089295e based on the discussion here: #2233 (comment) |
holgerd77
reviewed
Aug 31, 2022
| @@ -657,7 +657,7 @@ export class Trie { | |||
| } as PutBatch | |||
| }) | |||
|
|
|||
| if (this.root() === this.EMPTY_TRIE_ROOT && isTruthy(opStack[0])) { | |||
| if (this.root() === this.EMPTY_TRIE_ROOT && opStack[0] !== undefined && opStack[0] !== null) { | |||
There was a problem hiding this comment.
Yeah, but totally love all this (have taken a random line to comment 😋)!!!
This is structurally such an improvement for the whole library suite! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the trie package from #2233